Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix childnode typo #224

Merged
merged 1 commit into from
May 16, 2024

Conversation

bjthehun
Copy link
Contributor

Fixes #201:

  • Renamed modelNode occurences to childNode.
  • Also: processContainer calls had a cancelToken that was never defined; I removed its occurences.

I also updated website dependencies to fix vulnerabilities that npm reported, by running npm audit fix --force.

@bjthehun bjthehun temporarily deployed to pull-request-preview April 12, 2024 10:11 — with GitHub Actions Inactive
Copy link

github-actions bot commented Apr 12, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-05-16 09:55 UTC

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes to the guide look good. Though, I'm not sure we should include the update to the vite dependency in this PR. We probably update that one in a separate PR together with our other dependencies.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind that I've removed the contents of #225 from this PR. Looks good to me, thanks 👍

Also: remove unused cancelToken
@msujew msujew force-pushed the 201-fix-scoping-guide-typos branch from 9c9a158 to f51ab26 Compare May 16, 2024 09:44
@msujew msujew merged commit f55b338 into eclipse-langium:main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qualified Name Scoping has an error in the code example
2 participants